Add hook that returns disabled value in RowContext

[gwyneplaine]

WHY are these changes introduced?

We don't yet expose the disabled value for children of the RowContext.Provider to consume.
This is something we discovered we need in the following web PR
See problem outlined in the following comment.

We already expose the hover and selected context values via the useRowHovered and useRowSelected hooks respectively. This aligns with that convention.

WHAT is this pull request doing?

Following convention established in the useRowHovered and useRowSelected hooks to return as small a slice of state as possible, we expose a useRowDisabled hook so that context children can access the disabled state of the parent Row. (Needed for https://github.com/Shopify/web/pull/121521)

How to 🎩

🖥 Local development instructions
🗒 General tophatting guidelines
📄 Changelog guidelines

🎩 checklist

• Tested a snapshot
• Tested on mobile
• Tested on multiple browsers
• Tested for accessibility
• Updated the component's README.md with documentation changes
• Tophatted documentation changes in the style guide

[sam-b-rose]

This looks good to me! Though, would it be better to have a single hook for getting RowContext data, then adding more context data as needed?

const {disabled, hovered, selected, ...etc } = useIndexTableRow()

Then we could clean up the single-property hooks like useRowHovered and useRowSelected.

[gwyneplaine]

This looks good to me! Though, would it be better to have a single hook for getting RowContext data, then adding more context data as needed?

const {disabled, hovered, selected, ...etc } = useIndexTableRow()

Then we could clean up the single-property hooks like useRowHovered and useRowSelected.

Absolutely down to combine all consumption of RowContext into one useIndexTableRow hook. Caveat being that the hover value needs to be separate, and in fact currently belongs to a separate context RowHoverContext.

The choice to keep that in its own context provider was to reduce the potential performance hit of leaf nodes rerendering due to hover state changing in context, when other context values that are less frequently updated are being used. (Since context updates only re-renders for children that use that context, not all children of the context provider)

Happy to combine selected and disabled in a subsequent PR 👍

[translation-platform]

Localization quality issues found

The following issues may affect the quality of localized translations if they are not addressed:

• The value Clear for key Polaris.ActionList.SearchField.clearButtonLabel is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
• The value Search for key Polaris.ActionList.SearchField.search is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.
• The value Search actions for key Polaris.ActionList.SearchField.placeholder is very short. Short strings are more likely to be misunderstood by translators without context. Please provide additional context for the translators if possible.

Please look out for other instances of this issue in your PR and fix them as well if possible.

Questions about these messages? Hop in the #help-localization Slack channel.

[github-actions]

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.