Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropzone not respecting height and inverted drop area when inside Modal #12204

Open
joseclaudio-shopify opened this issue Jun 5, 2024 · 0 comments
Labels
Bug Something is broken and not working as intended in the system. untriaged

Comments

@joseclaudio-shopify
Copy link

joseclaudio-shopify commented Jun 5, 2024

Summary

We are experiencing strange behavior when using the Dropzone component within the modal in @shopify/app-bridge-react. Specifically:

  • the Dropzone does not respect the modal height, but this issue is fixed after resizing the screen.
  • the Dropzone area is actually inverted, becoming unable to drop files if hovered in the Dropzone area.

My app is the shop-importer-app, and the code was based on the web.

Expected behavior

When opening the modal, the Dropzone shows the correct layout similar to Admin -> Products -> Import 👇 Screenshot 2024-06-05 at 16 35 26
When hovering a file, should not invert the Dropzone area 👇 Screenshot 2024-06-05 at 16 40 54

Actual behavior

Dropzone does not respect the modal height Screenshot 2024-06-05 at 17 02 43
Screen.Recording.2024-06-03.at.12.40.25.1.mov
Dropzone area is actually inverted Screenshot 2024-06-05 at 17 03 03 Screenshot 2024-06-05 at 17 03 19
Screen.Recording.2024-05-28.at.3.45.11.PM.mov

Steps to reproduce

Unfortunately the app has not released yet, you can reach out to pair or similar

Are you using React components?

Yes

Polaris version number

@shopify/polaris: ^13.4.0 => 13.4.0

Browser

Chrome: 125.0.6422.142

Device

macOS 14.5

@joseclaudio-shopify joseclaudio-shopify added Bug Something is broken and not working as intended in the system. untriaged labels Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken and not working as intended in the system. untriaged
Projects
None yet
Development

No branches or pull requests

1 participant