Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-weight and letter-spacing for Inter font #9782

Closed
wants to merge 8 commits into from

Conversation

aaronccasanova
Copy link
Member

@aaronccasanova aaronccasanova commented Jul 20, 2023

WIP

Closes https://github.com/Shopify/polaris-summer-editions/issues/972

This PR applies a collection of typography changes following the recent introduction of the Inter font:

  • Updated and added font-weight tokens
  • Added letter-spacing tokens
  • Reorganized Text composite token variants into Sass mixins
    • These are consumed by the Text variant classes. However, we will now have access to these composite styles in stylesheets that haven't or can't upgrade to use Text
    • TODO: Replace hard coded font tokens with text-* mixins in all components (quickly counted +200 instances)
  • Updated the Storybook Google Fonts URL to use the weight range syntax
    • TODO: Add documentation containing a brief snippet for consumers

Screenshot 2023-07-20 at 11 01 29 AM

@aaronccasanova aaronccasanova self-assigned this Jul 20, 2023
@aaronccasanova aaronccasanova added the 🤖Skip Changelog Causes CI to ignore changelog update check. label Jul 20, 2023
@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

@aaronccasanova
Copy link
Member Author

/snapit

@github-actions
Copy link
Contributor

🫰✨ Thanks @aaronccasanova! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]
yarn add @shopify/[email protected]

Copy link
Contributor

Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity 🤖Skip Changelog Causes CI to ignore changelog update check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant