[ActionList][Item] Fix overflow on popover #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/snapit |
|
🫰✨ Thanks @zakwarsame! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
|
/snapit |
|
🫰✨ Thanks @zakwarsame! Your snapshots have been published to npm. Test the snapshots by updating your yarn add @shopify/[email protected]yarn add @shopify/[email protected]yarn add @shopify/[email protected] |
kyledurand
approved these changes
Aug 1, 2023
Merged
fortmarek
pushed a commit
that referenced
this pull request
Aug 3, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @shopify/[email protected] ### Minor Changes - [#9858](#9858) [`3fc3d5923`](3fc3d59) Thanks [@ardakaracizmeli](https://github.com/ardakaracizmeli)! - Added SidekickMajor - [#9871](#9871) [`bac86a621`](bac86a6) Thanks [@fortmarek](https://github.com/fortmarek)! - Added displayName to transpiled icons - [#9854](#9854) [`5dabf0fe0`](5dabf0f) Thanks [@heyjoethomas](https://github.com/heyjoethomas)! - Updated CancelMajor and CancelMinor icons ## @shopify/[email protected] ### Minor Changes - [#9697](#9697) [`c078d5d85`](c078d5d) Thanks [@nat-king](https://github.com/nat-king)! - Added optional prop `TextDecorationLine` to `Text` to include a line-through decoration ### Patch Changes - [#9847](#9847) [`85b68a358`](85b68a3) Thanks [@qt314](https://github.com/qt314)! - Added `role` prop to `VerticalStack` - [#9863](#9863) [`4061fd04d`](4061fd0) Thanks [@zakwarsame](https://github.com/zakwarsame)! - Fixed ActionList item overflow and tooltip zIndex - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`bac86a621`](bac86a6), [`5dabf0fe0`](5dabf0f)]: - @shopify/[email protected] ## @shopify/[email protected] ## [email protected] ### Patch Changes - Updated dependencies \[[`3fc3d5923`](3fc3d59), [`85b68a358`](85b68a3), [`bac86a621`](bac86a6), [`4061fd04d`](4061fd0), [`5dabf0fe0`](5dabf0f), [`c078d5d85`](c078d5d)]: - @shopify/[email protected] - @shopify/[email protected] Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this pull request
Apr 22, 2024
<!-- ☝️How to write a good PR title: - Prefix it with [ComponentName] (if applicable), for example: [Button] - Start with a verb, for example: Add, Delete, Improve, Fix… - Give as much context as necessary and as little as possible - Prefix it with [WIP] while it’s a work in progress --> ### WHY are these changes introduced? Fixes Shopify/core-workflows#1064 <!-- Context about the problem that’s being addressed. --> - When the popover is expanded, indented items in the account menu are overflowing instead of truncating properly. <details> <summary> Expand for screenshot: </summary> <img src="https://github.com/Shopify/core-workflows/assets/42528878/e19693b8-0071-44e7-b001-14978ef5699f" alt="bug screenshot" width="250px" height="auto" /> </details> - When hovering over items, the tooltip does not show because it's behind the Popover. <details> <summary> Expand for screenshot: </summary> <img src="https://github.com/Shopify/polaris/assets/42528878/47daa261-a73d-4a96-95ed-29d62d2444bb" alt="bug screenshot" width="250px" height="auto" /> </details> ### WHAT is this pull request doing? <!-- Summary of the changes committed. Before / after screenshots are appreciated for UI changes. Make sure to include alt text that describes the screenshot. If you include an animated gif showing your change, wrapping it in a details tag is recommended. Gifs usually autoplay, which can cause accessibility issues for people reviewing your PR: <details> <summary>Summary of your gif(s)</summary> <img src="..." alt="Description of what the gif shows"> </details> --> - Applies a max-width to the indented items - Applies a higher z-Index on tooltips <!-- ℹ️ Delete the following for small / trivial changes --> ### How to 🎩 [Spin URL](https://admin.web.fx.zakaria-warsame.us.spin.dev/store/shop2/) - Ensure the account menu items are truncating properly and not overflowing. - Hover over the items ensure the tooltip shows up on top of the popover. </details> ### 🎩 checklist - [x] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [x] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) ~- [ ] Updated the component's `README.md` with documentation changes~ - [x] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/core-workflows/issues/1064
Expand for screenshot:
Expand for screenshot:
WHAT is this pull request doing?
How to 🎩
Spin URL
🎩 checklist
- [ ] Updated the component'sREADME.mdwith documentation changes