-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Epic] Globally remove all conditional se23 logic from polaris-react #9915
Labels
Priority: High
Clear visual regression, broken logic, or feature UX will feel broken without
Comments
5 tasks
sophschneider
changed the title
Remaining feature flag cleanup
[Epic] Globally remove all conditional se23 logic from polaris-react
Aug 23, 2023
sophschneider
added
the
Priority: High
Clear visual regression, broken logic, or feature UX will feel broken without
label
Sep 20, 2023
We can resume this work once #10423 ships :D |
5 tasks
5 tasks
laurkim
added a commit
that referenced
this issue
Sep 22, 2023
### WHY are these changes introduced? Resolves #9915. Resolves #10189. Resolves #10190. Resolves #10192. Resolves #10193. Consolidates se23 logic (passing in `polarisSummerEditions2023` to `features`) in AppProvider and related components. ### WHAT is this pull request doing? Removes se23 flag from features and consolidates se23 comments. Adds comment with warning to discourage use of `se23` flag in `_common.scss`. ### How to 🎩 [Storybook]() [Next branch storybook](https://5d559397bae39100201eedc1-kzivkxiyci.chromatic.com/?path=/story/playground--details-page) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
AnnaCheba
pushed a commit
to AnnaCheba/polaris
that referenced
this issue
Apr 22, 2024
### WHY are these changes introduced? Resolves Shopify#9915. Resolves Shopify#10189. Resolves Shopify#10190. Resolves Shopify#10192. Resolves Shopify#10193. Consolidates se23 logic (passing in `polarisSummerEditions2023` to `features`) in AppProvider and related components. ### WHAT is this pull request doing? Removes se23 flag from features and consolidates se23 comments. Adds comment with warning to discourage use of `se23` flag in `_common.scss`. ### How to 🎩 [Storybook]() [Next branch storybook](https://5d559397bae39100201eedc1-kzivkxiyci.chromatic.com/?path=/story/playground--details-page) 🖥 [Local development instructions](https://github.com/Shopify/polaris/blob/main/README.md#local-development) 🗒 [General tophatting guidelines](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md) 📄 [Changelog guidelines](https://github.com/Shopify/polaris/blob/main/.github/CONTRIBUTING.md#changelog) ### 🎩 checklist - [ ] Tested on [mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing) - [x] Tested on [multiple browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers) - [ ] Tested for [accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md) - [ ] Updated the component's `README.md` with documentation changes - [ ] [Tophatted documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md) changes in the style guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
after #9913 is completed we need to
Tasks
polaris-react/src/styles
#10193Note
We can remove
$se23ShadowBevelOptOut
but not$se23
since a lot of our consuming repos still use the classname and we don't want to affect their styles.Sources:
The text was updated successfully, but these errors were encountered: