Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataTable] Consolidate se23 logic and styles #9930

Closed
Tracked by #9913
sophschneider opened this issue Aug 9, 2023 · 0 comments
Closed
Tracked by #9913

[DataTable] Consolidate se23 logic and styles #9930

sophschneider opened this issue Aug 9, 2023 · 0 comments
Assignees
@sophschneider

Comments

@sophschneider
Copy link
Contributor

No description provided.

@sophschneider sophschneider mentioned this issue Aug 9, 2023
Closed
@sophschneider sophschneider self-assigned this Aug 22, 2023
@sophschneider sophschneider mentioned this issue Aug 22, 2023
Merged
sophschneider added a commit that referenced this issue Aug 23, 2023
@sophschneider
[DataTable] Consolidate conditional logic (#10169)
3a19bb9 
### WHY are these changes introduced?

Fixes #9930

### WHAT is this pull request doing?

* Consolidate se23 logic and styles for `DataTable` Component

### How to 🎩
* Compare production and this PR's chromatic storybook to make sure
styles are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datatable--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-bhdulauigv.chromatic.com/?path=/story/all-components-datatable--default)
sophschneider added a commit that referenced this issue Sep 19, 2023
@sophschneider
[DataTable] Consolidate conditional logic (#10169)
f9eee11 
### WHY are these changes introduced?

Fixes #9930

### WHAT is this pull request doing?

* Consolidate se23 logic and styles for `DataTable` Component

### How to 🎩
* Compare production and this PR's chromatic storybook to make sure
styles are the same


[Production](https://storybook.polaris.shopify.com/?path=/story/all-components-datatable--default&globals=polarisSummerEditions2023:true)
[This
PR](https://5d559397bae39100201eedc1-bhdulauigv.chromatic.com/?path=/story/all-components-datatable--default)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophschneider sophschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sophschneider