Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Popover] Consolidate se23 logic and styles #9958

Closed
Tracked by #9913
sophschneider opened this issue Aug 9, 2023 · 0 comments
Closed
Tracked by #9913

[Popover] Consolidate se23 logic and styles #9958

sophschneider opened this issue Aug 9, 2023 · 0 comments
Assignees
@gwyneplaine

Comments

@sophschneider
Copy link
Contributor

No description provided.

@sophschneider sophschneider mentioned this issue Aug 9, 2023
Closed
@gwyneplaine gwyneplaine self-assigned this Aug 18, 2023
@gwyneplaine gwyneplaine mentioned this issue Aug 18, 2023
Merged
5 tasks
gwyneplaine added a commit that referenced this issue Aug 21, 2023
@gwyneplaine
[Popover] consolidate se23 styles and logic (#10114)
3ed1146 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9958

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- `Popover` consolidate se23 logic
- `Popover` consolidate se23 styles

### How to 🎩

-
[Storybook](https://5d559397bae39100201eedc1-qinvshnolg.chromatic.com/?path=/story/all-components-popover--all)
- [Production
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-popover--all&globals=polarisSummerEditions2023:true)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@gwyneplaine @sophschneider
[Popover] consolidate se23 styles and logic (#10114)
c76cb43 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes #9958

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- `Popover` consolidate se23 logic
- `Popover` consolidate se23 styles

### How to 🎩

-
[Storybook](https://5d559397bae39100201eedc1-qinvshnolg.chromatic.com/?path=/story/all-components-popover--all)
- [Production
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-popover--all&globals=polarisSummerEditions2023:true)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@gwyneplaine
[Popover] consolidate se23 styles and logic (Shopify#10114)
962a83f 
<!--
  ☝️How to write a good PR title:
- Prefix it with [ComponentName] (if applicable), for example: [Button]
  - Start with a verb, for example: Add, Delete, Improve, Fix…
  - Give as much context as necessary and as little as possible
  - Prefix it with [WIP] while it’s a work in progress
-->

### WHY are these changes introduced?

Fixes Shopify#9958

<!--
  Context about the problem that’s being addressed.
-->

### WHAT is this pull request doing?

- `Popover` consolidate se23 logic
- `Popover` consolidate se23 styles

### How to 🎩

-
[Storybook](https://5d559397bae39100201eedc1-qinvshnolg.chromatic.com/?path=/story/all-components-popover--all)
- [Production
storybook](https://storybook.polaris.shopify.com/?path=/story/all-components-popover--all&globals=polarisSummerEditions2023:true)

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gwyneplaine gwyneplaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gwyneplaine @sophschneider