Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar - shape to variant, customer to variant (needs design) #9977

Closed
3 tasks done
Tracked by #9914
kyledurand opened this issue Aug 9, 2023 · 0 comments
Closed
3 tasks done
Tracked by #9914

Avatar - shape to variant, customer to variant (needs design) #9977

kyledurand opened this issue Aug 9, 2023 · 0 comments
Assignees
@aveline @sam-b-rose
Labels
#gsd:36573 Polaris API Alignment

Comments

@kyledurand
Copy link
Member

kyledurand commented Aug 9, 2023 •
edited by sam-b-rose
Loading

Prop changes
Beta Give feedback
@kyledurand kyledurand mentioned this issue Aug 9, 2023
Closed
@kyledurand kyledurand added v12 and removed untriaged labels Aug 9, 2023
@sam-b-rose sam-b-rose added #gsd:36573 Polaris API Alignment and removed v12 labels Aug 15, 2023
@aveline aveline self-assigned this Aug 18, 2023
@aveline aveline mentioned this issue Aug 18, 2023
Merged
aveline added a commit that referenced this issue Aug 21, 2023
@aveline
[Avatar] Remove shape (#10122)
43b42ae 
### WHY are these changes introduced?

Fixes #9977

### WHAT is this pull request doing?

- Removes the `shape` prop from `Avatar` as now there is only the
squircle shape
- Cleaned up the `Avatar` stories
@aveline aveline closed this as completed Aug 21, 2023
@sam-b-rose sam-b-rose reopened this Aug 30, 2023
@sam-b-rose sam-b-rose mentioned this issue Aug 30, 2023
Merged
13 tasks
@sam-b-rose sam-b-rose self-assigned this Sep 13, 2023
sam-b-rose added a commit that referenced this issue Sep 14, 2023
@sam-b-rose @aveline
[Avatar] Remove customer prop and experiemntal values (#10283)
42ee9f4 
### WHY are these changes introduced?

Fixes #9977

### WHAT is this pull request doing?

- [x] Remove `customer` boolean prop (make the default)
- [x] Remove `-experimental` from `size` prop
- [x] Update Avatar stories
- [x] Update Avatar documentation examples
- [x] Update `v12` migration guide
- [x] Write migration for `Avatar` prop changes 
  - [x] remove `customer` prop
  - [x] `size` prop mapping

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: aveline <[email protected]>
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@aveline @sophschneider
[Avatar] Remove shape (#10122)
c28c615 
### WHY are these changes introduced?

Fixes #9977

### WHAT is this pull request doing?

- Removes the `shape` prop from `Avatar` as now there is only the
squircle shape
- Cleaned up the `Avatar` stories
sophschneider pushed a commit that referenced this issue Sep 19, 2023
@sam-b-rose @aveline @sophschneider
[Avatar] Remove customer prop and experiemntal values (#10283)
377de3f 
### WHY are these changes introduced?

Fixes #9977

### WHAT is this pull request doing?

- [x] Remove `customer` boolean prop (make the default)
- [x] Remove `-experimental` from `size` prop
- [x] Update Avatar stories
- [x] Update Avatar documentation examples
- [x] Update `v12` migration guide
- [x] Write migration for `Avatar` prop changes 
  - [x] remove `customer` prop
  - [x] `size` prop mapping

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: aveline <[email protected]>
AnnaCheba pushed a commit to AnnaCheba/polaris that referenced this issue Apr 22, 2024
@sam-b-rose @aveline
[Avatar] Remove customer prop and experiemntal values (Shopify#10283)
15352ad 
### WHY are these changes introduced?

Fixes Shopify#9977

### WHAT is this pull request doing?

- [x] Remove `customer` boolean prop (make the default)
- [x] Remove `-experimental` from `size` prop
- [x] Update Avatar stories
- [x] Update Avatar documentation examples
- [x] Update `v12` migration guide
- [x] Write migration for `Avatar` prop changes 
  - [x] remove `customer` prop
  - [x] `size` prop mapping

### 🎩 checklist

- [ ] Tested on
[mobile](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting.md#cross-browser-testing)
- [ ] Tested on [multiple
browsers](https://help.shopify.com/en/manual/shopify-admin/supported-browsers)
- [ ] Tested for
[accessibility](https://github.com/Shopify/polaris/blob/main/documentation/Accessibility%20testing.md)
- [ ] Updated the component's `README.md` with documentation changes
- [ ] [Tophatted
documentation](https://github.com/Shopify/polaris/blob/main/documentation/Tophatting%20documentation.md)
changes in the style guide

---------

Co-authored-by: Sam Rose <[email protected]>
Co-authored-by: aveline <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aveline aveline

@sam-b-rose sam-b-rose

Labels
#gsd:36573 Polaris API Alignment
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aveline @kyledurand @sam-b-rose