[WIP] Polaris tokens base/variant themes #9877
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-tokens-themes
…s-tokens-themes
…s-tokens-themes
aaronccasanova
force-pushed
the
polaris-tokens-themes
branch
from
02dfe19
to
b8b995f
Compare
github-actions
bot
added
the
cla-needed
|
Hi! We noticed there hasn’t been activity on this PR in a while. After 30 days, it will close automatically. If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explores a base/variant theme architecture for Polaris tokens where the base theme is the foundation for any number of variant themes. Variant themes have two primary constraints in that they can only extend the base theme and they are the only theme exposed to consumers.
One advantage of this pattern is that system changes can be made more predictably by flattening the relationship between themes (without needing to consider deeply inherited themes). For example:
❌ With deeply inherited themes
flowchart TD A[Base Theme] A --> B[Light Theme] B --> C[Light High Contrast Theme] A --> D[Dark Theme] D --> E[Dark High Contrast Theme] A --> F[Dim Theme] A --> G[etc...]✅ With base/variant themes
flowchart TD A[Base Theme] A --> B[Light Theme] A --> C[Light High Contrast Theme] A --> D[Dark Theme] A --> E[Dark High Contrast Theme] A --> F[Dim Theme] A --> G[etc...]Note:
@shopify/polaris-tokenscontinues to generate a single source of truth stylesheet but separates base and variant theme custom properties into dedicated selectors to reduce duplication: