-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RecursionError when pulling more than 475 pages of Orders #445
Comments
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
If it is not fixed, I advise the bot to NOT close this ticket. |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
Hi! I have the same issue as @tomaszsmolarek :/. |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
We're also facing the same problem. :( |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
not resolved, still relevant, not stale |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
not resolved, still relevant, not stale |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
Not fixed, please don't close. |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
still happens, not fixed |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
not solved |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
Isn't shopify, a company with millions of users and revenue, interested in fixing this? |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
not fixed, still a problem |
Could you provide a code example that produces the error? |
This issue is stale because it has been open for 60 days with no activity. It will be closed if no further action occurs in 14 days. |
Has it been resolved? If not, why close it? |
Issue summary
When one pulls Orders data from API with auto-iteraton (
no_iter_next=True
), library iterates over pages and when it hits page 476 an error is thrown.Also, looks like there are memory problems because of this recursion as our servers just die and we have to reboot them, although I have no clear evidence of this.
It's unknown if this impacts other data type (Customers, Products...) - although it's very likely it does as the code that crashes is generic collections code.
edited: Seems like default recursion limit in py3 is 1000.
The code does 2 * 475 = 950 iterations. Looks like 50 is for other operations the code is doing. The code crashes at the same place, always.
Expected behavior
No error is thrown, code continues.
Actual behavior
Error is thrown:
Steps to reproduce the problem
Specifications
shopify_python_api
version: 6.0.1 and 8.1.0 (possible more versions)'2020-07'
): 2020-01 and 2020-07 (possible more versions)The text was updated successfully, but these errors were encountered: