prefer-early-return doesn't work when there is a variable #314

BenjaminVanRyseghem · 2021-12-21T11:01:34Z

Overview

When extracting the if condition into a variable, the rule is suddenly satisfied.

Not sure if it's a bug or not, but this feel like it could be at least improved (yet I don't know if it's really feasible)

Examples:

The following is considered warning

	foo() {
		if (a) {
			b();
			c();
		}
	}

yet, the following is not

	foo() {
        var bar = a;
		if (bar) {
			b();
			c();
		}
	}

Checklist

Please delete the labels section before submitting your issue
I have described this issue in a way that is actionable (if possible)

The text was updated successfully, but these errors were encountered:

WesleyYue · 2023-05-13T04:02:38Z

This also doesn't work:

export function foo1(a: string) {
  if (a) {
    console.log(a);
  }
}

…s the last one in function body Sometimes we assign a conditions used in "if" test to a variable before "if" statement. In such case it's not the only statement in the block, but it should be detected anyway. closes Shopify#314

miluoshi linked a pull request Feb 8, 2024 that will close this issue

Add support for prefer-early-return to detect when "if" statement is the last one in function body #412

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

prefer-early-return doesn't work when there is a variable #314

prefer-early-return doesn't work when there is a variable #314

BenjaminVanRyseghem commented Dec 21, 2021 •

edited

Loading

WesleyYue commented May 13, 2023

prefer-early-return doesn't work when there is a variable #314

prefer-early-return doesn't work when there is a variable #314

Comments

BenjaminVanRyseghem commented Dec 21, 2021 • edited Loading

Overview

Checklist

WesleyYue commented May 13, 2023

BenjaminVanRyseghem commented Dec 21, 2021 •

edited

Loading