Skip to content

ONR-01 | Incomplete Workflow of Function OnRecPacketWhitelistConvert() #3169

@Brando753

Description

@Brando753

Affected Files: onrecv_packet.go L57

Description

As the comment states, the non-x versions of tokens received should be registered to the tokenRegistry module to allow the following token conversion operations. Without proper token registrations, the function call on line 58 will return an error and the following tokens conversions will not be executed.

convertToDenomEntry, err := whitelistKeeper.GetRegistryEntry(ctx, mintedDenomEntry.UnitDenom)

Recommendation

Recommend the Sifchian Team to complete the aforementioned workflow by validating and registering the non-x versions of tokens before further execution if necessary.

Metadata

Metadata

Assignees

Labels

MediumA Medium level security issue or medium level priorityPeggy 2.0An issue blocking the Peggy 2.0 releasePeggy TeamPeggy team taskPeggy2 Audit - Sifnode IssueIssue that came out of the Peggy2 audits that requires remediation by SifnodeSifnode Team

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions