This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Command line mode #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moozzyk Could you look this PR over? This adds a stand-alone version of the agent for use in a non-distributed fashion. |
| break; | ||
| case "worker": | ||
| ThreadPool.SetMinThreads(32, 32); |
There was a problem hiding this comment.
What are the default numbers and why 32 is good? Why we need to do this at all - the explanation should be in the code as well.
There was a problem hiding this comment.
I was attempting to address an issue with slow ramp-up and ramp-down, but there weren't any conclusive results. I'll just remove this until we have something definitive.
mikary
force-pushed
the
commandLineMode
branch
from
c5525d5
to
ad1883b
Compare
|
🚢🇮🇹 |
mikary
force-pushed
the
commandLineMode
branch
from
14be2ba
to
654ea3d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening new PR to replace #71
@davidfowl @abnanda1