Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The dictionary/get_fields_data/<datasetid>/ API endpoint always returns NGT data #1280

Open
vanlummelhuizen opened this issue Jun 27, 2024 · 2 comments
Assignees

Comments

@vanlummelhuizen
Copy link
Collaborator

No description provided.

@susanodd
Copy link
Collaborator

susanodd commented Jul 1, 2024

This probably happens if the user is not logged in?
The code (as written before adding the API token to it) had a fall-back to NGT when the user was not logged in, since it is public.

@vanlummelhuizen
Copy link
Collaborator Author

This probably happens if the user is not logged in?

No, when API authentication is correct (the user is logged in), the result was still only for NGT. For instance, curl --header 'Authorization:Bearer tSQICBglJoAYuGtz' https://signbank.cls.ru.nl/dictionary/get_fields_data/2/ (Kata Kolok) should give

{
    "fields": [
        "Lemma ID Gloss: Balinees",
        "Lemma ID Gloss: Indonesisch",
        "Lemma ID Gloss: Engels",
        "Annotation ID Gloss: Balinees",
        "Annotation ID Gloss: Indonesisch",
        "Annotation ID Gloss: Engels",
        "Senses: Balinees",
        "Senses: Indonesisch",
        "Senses: Engels",
        ...
    ]
}

but gives

{
  "fields": [
    "Lemma ID Gloss: Dutch",
    "Lemma ID Gloss: English",
    "Annotation ID Gloss: Dutch",
    "Annotation ID Gloss: English",
    "Senses: Dutch",
    "Senses: English",
    ...
  ]
}

This is now fixed in PR #1279 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants