Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

silk-paper release requirements #57

Open
jakobkmar opened this issue Jul 1, 2024 · 2 comments
Open

silk-paper release requirements #57

jakobkmar opened this issue Jul 1, 2024 · 2 comments
Labels
paper This issue paper specific

Comments

@jakobkmar
Copy link
Member

jakobkmar commented Jul 1, 2024

Since Paper removed the version strings from most packages, it is easier now than ever to fully implement silk-paper.
In the past year, I also removed all dependencies on fabric-api, so Silk is standalone in that regard,

What still needs to be done:

  • all Silk events also need to be called on paper
    • which should be done like this:
      1. listen to paper event
      2. call silk event inside there
      3. handle changed state correctly
    • I aim to write a simple compiler plugin (be it KSP or possibly something with K2) to check whether all events have been implemented, or fail / warn otherwise - but this is not a requirement for the first silk-paper release
  • Silk sometimes uses accessors on Fabric to access private / protected Minecraft fields and classes, this probably needs a reflection replacement on paper

I won't be able to begin with this within the next 1 1/2 months, however if anyone wants to take the lead and get this done it would be greatly appreciated.

@jakobkmar jakobkmar added the paper This issue paper specific label Jul 1, 2024
@DinoMarlir
Copy link

Silk-Paper will replace KSpigot, right?

@jakobkmar
Copy link
Member Author

Yes, KSpigot can be continued by anyone who wants to maintain it, but I would definitely recommend to switch since the APIs in Silk are more refined.

@jakobkmar jakobkmar pinned this issue Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paper This issue paper specific
Projects
None yet
Development

No branches or pull requests

2 participants