Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report of a problem (and fix suggestion) about sensor status message parsing #111

Open
diocorreia opened this issue Mar 30, 2021 · 3 comments

Comments

@diocorreia
Copy link

Hello,

I think to have found a small issue with the parsing of the Sensor Status message. The parsing method stops, when sensor_setting_raw is empty, due to the length field value being 0x7F (128) instead of 0x00 (0). I solved the issue by adding
length = (length % 128) on the line number 165.

length = (property_id[0] >> 1) + 1

@diocorreia diocorreia changed the title Problem during sensor status message parsing Report of a problem (and fix suggestion) about sensor status message parsing Mar 30, 2021
@michallowasrzechonek-silvair
Copy link
Contributor

Do you have a sample message, in binary/hex?

@diocorreia
Copy link
Author

I'm using a node with a nRF Connect SDK sensor_server sample flashed on it. The sensor status message (in hex) I get, when I send an SENSOR_SERIES_GET message, is '52ff4d00820a1b08ff6400220d0000'. I've already tested the node with nRF Mesh android app, and the node seems OK.

@michallowasrzechonek-silvair
Copy link
Contributor

Thanks, I'll look into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants