Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear of different iLvl not working #11

Open
scainburger opened this issue Dec 22, 2017 · 1 comment
Open

Gear of different iLvl not working #11

scainburger opened this issue Dec 22, 2017 · 1 comment
Assignees
Labels

Comments

@scainburger
Copy link

scainburger commented Dec 22, 2017

Adding gear via "Add Items" and changing the iLvl does not actually update the iLvl of the item. Selecting two pieces of the same gear with changed iLvl only generates a single profile for SimC export as the items are actually recognized as the same iLvl.

For example, I have added Khaz'goroth's Courage at iLvl 960 (5 higher than my current). This is what I see after clicking "generate": https://i.imgur.com/6vVWDtv.png

I expected to see another copy with the 960 Khaz'goroth's replacing the 955 but this does not happen as SimPermut thinks I've selected two 955s.

Also, only selecting the 960 and deselecting the 955 still uses a 955 in the sim.

Edit: It's worth noting that if I add a different piece to the sim (in my case, a helm, not the same name/item), it successfully creates profiles for the trinkets with different iLvls.

@Kutikuti
Copy link
Member

Kutikuti commented Jan 4, 2018

Hi, thanks for the report.
I see why it doesn't work for ring/trinket as the system to detect permutation of these item slot is based on the id and not ilvl.
I'll try to come with a fix but this might not be easy

@Kutikuti Kutikuti self-assigned this Jan 4, 2018
@Kutikuti Kutikuti added the bug label Jan 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants