Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better examples in documentation #64

Closed
mrp089 opened this issue Jul 9, 2020 · 2 comments · Fixed by #68
Closed

Better examples in documentation #64

mrp089 opened this issue Jul 9, 2020 · 2 comments · Fixed by #68
Assignees

Comments

@mrp089
Copy link
Member

mrp089 commented Jul 9, 2020

Change the examples in the documentation. Use current test cases and only mention currently tested functionality (#53).

@mrp089 mrp089 self-assigned this Jul 9, 2020
@mrp089
Copy link
Member Author

mrp089 commented Sep 10, 2020

I changed the documentation:

  • removed old examples
  • add example for simple tube with resistance boundary condition (test case, analytical results, simulation results)
  • add example for bifurcation with RCR boundary conditions (test case, literature reference, simulation results)

@melodydong I had to change the test case bifurcation_RCR.in to match the results in [xiao13] (elastic wall, distal resistance in RCR, number of cycles, smoothness of inflow profile, test values). The results seem to match with the ones in Figure 11.

@mrp089
Copy link
Member Author

mrp089 commented Sep 10, 2020

Update documentation of supported boundary conditions (BCs):

  • delete BCs that are no longer supported
  • distinguish between inlet and outlet BCs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant