Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChamberElastanceInductor to configure #140

Open
1 task done
alexkaiser opened this issue Nov 28, 2024 · 0 comments
Open
1 task done

Add ChamberElastanceInductor to configure #140

alexkaiser opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@alexkaiser
Copy link

Use Case

The calibrate program currently does not modify parameters in the Chamber blocks. I would like to automatically calibrate the chamber parameters in an LPN.

Problem

This will allow users to tune parameters in more of the existing blocks automatically.

Solution

The function update_gradient should be added to ChamberElastanceInductor.cpp. Code to include the chamber should be added to calibrate.cpp.

Alternatives considered

An initial attempt that does not yet work is in https://github.com/alexkaiser/svZeroDSolver/tree/chamber_calibrate. This fails, at least in part, because parameters are time dependent in the block and the calibrator does not update time like the solver does. I opened a separate issue for updating time-dependent parameters, #139, because that is a more general need than that of adding chambers to calibrate.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
@alexkaiser alexkaiser added the enhancement New feature or request label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant