Fix small bugs #219
Closed
Fix small bugs #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
create pull requests one by one please, it is hard to test or maintain like this. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the following issues:
-[BUG] Sign on display doesn't change after division by zero or mod 0
Now we don't allow to users to change/enter the sign after division/mod 0, it remains "÷" or "%" respectievly.
Users only can insert new denomiator for division operation.
-[BUG] Sign wrong changing to plus after division by zero
The issue was caused by getSign() function, in which if lastOperation was not defined we assigned result to "+" in else branch of "when" statement
Now we don't allow to users to change the sign but only the denominator for division.
-[BUG] Mod wrong result
Now the result of the n%n% is zero.
-[BUG] Crash after putting second sign after mod 0
Now we do not allow to users to put any sign after displaying the error message in case of mod 0.
Users only can insert the second value for mod operation.
#201 and #202 fixed
#204 fixed
#218 fixed
