From 1e5aa7b4896fb736be744035eda443035be80b69 Mon Sep 17 00:00:00 2001
From: Saphire <lattice@saphi.re>
Date: Sat, 30 Nov 2024 12:37:42 +0600
Subject: [PATCH] Fix feedback issues

---
 ReplayBrowser/Helpers/ReplayHelper.cs      |  4 ++--
 ReplayBrowser/Pages/Search.razor           |  1 -
 ReplayBrowser/Pages/Shared/SearchBar.razor | 10 ++++------
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/ReplayBrowser/Helpers/ReplayHelper.cs b/ReplayBrowser/Helpers/ReplayHelper.cs
index 6cadc18..f3f074e 100644
--- a/ReplayBrowser/Helpers/ReplayHelper.cs
+++ b/ReplayBrowser/Helpers/ReplayHelper.cs
@@ -14,7 +14,7 @@ namespace ReplayBrowser.Helpers;
 
 public class ReplayHelper
 {
-    static readonly string REDACTION_MESSAGE = "The account you are trying to search for is private or deleted. This might happen for various reasons as chosen by the account owner or the site administrative decision";
+    const string REDACTION_MESSAGE = "The account you are trying to search for is private or deleted. This might happen for various reasons as chosen by the account owner or the site administrative decision";
 
     private readonly IMemoryCache _cache;
     private readonly ReplayDbContext _context;
@@ -306,7 +306,7 @@ public static void CheckAccountAccess(Account? caller, Account? found)
             return;
 
         // Is there any redaction to worry about?
-        if (!found.Settings.RedactInformation && !found.Protected)
+        if (!found.Settings.RedactInformation)
             return;
         // Ah shit
 
diff --git a/ReplayBrowser/Pages/Search.razor b/ReplayBrowser/Pages/Search.razor
index 77d2a49..93dcd1d 100644
--- a/ReplayBrowser/Pages/Search.razor
+++ b/ReplayBrowser/Pages/Search.razor
@@ -233,7 +233,6 @@
             ErrorMessage = "Invalid search query";
             ErrorDetails = "No search items found";
             stopWatch.Stop();
-            NavigationManager.NavigateTo("/");
             return;
         }
 
diff --git a/ReplayBrowser/Pages/Shared/SearchBar.razor b/ReplayBrowser/Pages/Shared/SearchBar.razor
index 451c599..479ee19 100644
--- a/ReplayBrowser/Pages/Shared/SearchBar.razor
+++ b/ReplayBrowser/Pages/Shared/SearchBar.razor
@@ -49,7 +49,7 @@
 
 <div class="search-bar">
 @{
-    RenderLine(null);
+    RenderLine(null); // Renders the prefab template so the JS code has something to hydrate later
     foreach (var item in Items ?? []) {
         RenderLine(item);
     }
@@ -188,13 +188,11 @@
             autocompleter._config.filter = null;
     }
 
-    /** @@param {{searchMode: test}} initialValue */
+    /** @@param {HTMLDivElement} [searchLine] */
     async function createSearchBar(searchLine) {
         if (!searchLine) {
-            /** @@type {HTMLCollectionOf<HTMLDivElement>} */
-            const searchBarPrefab = document.getElementsByClassName('prefab');
-            /** @@type {HTMLDivElement} */
-            searchLine = searchBarPrefab[0].cloneNode(true);
+            const searchBarPrefab = document.querySelector('.search-form.prefab');
+            searchLine = searchBarPrefab.cloneNode(true);
             searchLine.classList.remove("hidden", "prefab");
             document.querySelector('.search-bar').appendChild(searchLine);
         }