Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] Duplicated tags on items #178

Open
ffuentesm opened this issue Dec 16, 2024 · 2 comments
Open

[1.21] Duplicated tags on items #178

ffuentesm opened this issue Dec 16, 2024 · 2 comments
Labels
question Further information is requested

Comments

@ffuentesm
Copy link

ffuentesm commented Dec 16, 2024

The mod is using outdated Tags and causing a duplicated entry. The correct tag id is "c:foods/vegetable" (not plural).
https://github.com/Sinytra/ForgifiedFabricAPI/blob/1.21.1/fabric-convention-tags-v2/src/generated/resources/data/c/tags/item/foods/vegetables.json

Carrots, Potatoes, beets, and Golden Carrots all have duplicated tags c:foods/vegetable and c:foods/vegetables
Image
Image
Image
Image

These are not just the only ones. Many other tags have changed and it's causing the duplicated tags.
https://github.com/neoforged/NeoForge/tree/1.21.x/src/generated/resources/data/c/tags/item

@ffuentesm ffuentesm changed the title [1.21] Duplicated vegetable tag on food items [1.21] Duplicated tags on items Dec 16, 2024
@Su5eD
Copy link
Member

Su5eD commented Dec 16, 2024

This seems to be consistent with upstream FAPI' tags. Are there any in-game side effects caused by this that would require attention?

@Su5eD Su5eD added the question Further information is requested label Dec 16, 2024
@ffuentesm
Copy link
Author

ffuentesm commented Dec 16, 2024

Yes, adding c:coal to the #minecraft:coals tag is breaking some of my recipes

This is causing the c:coal tag to be added to charcoal and coal coke items from other mods I have. It breaks the recipes that use the c:charcoal and c:coal_coke tags. To fix that, you just have to unappend the c:coal from the #minecraft:coals tag and instead add the minecraft:coal item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants