diff --git a/src/common/messages.cpp b/src/common/messages.cpp index 5d68eb3d7fc1d..c547ccb59d7d0 100644 --- a/src/common/messages.cpp +++ b/src/common/messages.cpp @@ -7,6 +7,7 @@ #include #include +#include #include #include #include @@ -18,6 +19,8 @@ #include #include +using node::TransactionError; + namespace common { std::string StringForFeeReason(FeeReason reason) { diff --git a/src/common/messages.h b/src/common/messages.h index bdd853791d326..68e7bb216966d 100644 --- a/src/common/messages.h +++ b/src/common/messages.h @@ -11,13 +11,15 @@ #ifndef BITCOIN_COMMON_MESSAGES_H #define BITCOIN_COMMON_MESSAGES_H -#include #include struct bilingual_str; enum class FeeEstimateMode; enum class FeeReason; +namespace node { +enum class TransactionError; +} // namespace node namespace common { enum class PSBTError; @@ -26,7 +28,7 @@ std::string StringForFeeReason(FeeReason reason); std::string FeeModes(const std::string& delimiter); std::string InvalidEstimateModeErrorMessage(); bilingual_str PSBTErrorString(PSBTError error); -bilingual_str TransactionErrorString(const TransactionError error); +bilingual_str TransactionErrorString(const node::TransactionError error); bilingual_str ResolveErrMsg(const std::string& optname, const std::string& strBind); bilingual_str InvalidPortErrMsg(const std::string& optname, const std::string& strPort); bilingual_str AmountHighWarn(const std::string& optname); diff --git a/src/interfaces/node.h b/src/interfaces/node.h index aeb2612c07850..2bb895dd47ce5 100644 --- a/src/interfaces/node.h +++ b/src/interfaces/node.h @@ -30,10 +30,10 @@ class RPCTimerInterface; class UniValue; class Proxy; enum class SynchronizationState; -enum class TransactionError; struct CNodeStateStats; struct bilingual_str; namespace node { +enum class TransactionError; struct NodeContext; } // namespace node namespace wallet { @@ -208,7 +208,7 @@ class Node virtual std::optional getUnspentOutput(const COutPoint& output) = 0; //! Broadcast transaction. - virtual TransactionError broadcastTransaction(CTransactionRef tx, CAmount max_tx_fee, std::string& err_string) = 0; + virtual node::TransactionError broadcastTransaction(CTransactionRef tx, CAmount max_tx_fee, std::string& err_string) = 0; //! Get wallet loader. virtual WalletLoader& walletLoader() = 0; diff --git a/src/interfaces/wallet.h b/src/interfaces/wallet.h index 1c916aacb0add..f7bcca58cf082 100644 --- a/src/interfaces/wallet.h +++ b/src/interfaces/wallet.h @@ -35,6 +35,9 @@ struct bilingual_str; namespace common { enum class PSBTError; } // namespace common +namespace node { +enum class TransactionError; +} // namespace node namespace wallet { class CCoinControl; class CWallet; diff --git a/src/node/interfaces.cpp b/src/node/interfaces.cpp index 216f44ab9e4be..164a3b97da9b8 100644 --- a/src/node/interfaces.cpp +++ b/src/node/interfaces.cpp @@ -31,6 +31,7 @@ #include #include #include +#include #include #include #include diff --git a/src/node/transaction.cpp b/src/node/transaction.cpp index b66a4f2f39ec6..591dcd698dd4e 100644 --- a/src/node/transaction.cpp +++ b/src/node/transaction.cpp @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include diff --git a/src/node/types.h b/src/node/types.h index 9dd2edebb5340..0461e85f4308f 100644 --- a/src/node/types.h +++ b/src/node/types.h @@ -13,6 +13,7 @@ #ifndef BITCOIN_NODE_TYPES_H #define BITCOIN_NODE_TYPES_H +namespace node { enum class TransactionError { OK, //!< No error MISSING_INPUTS, @@ -23,5 +24,6 @@ enum class TransactionError { MAX_BURN_EXCEEDED, INVALID_PACKAGE, }; +} // namespace node #endif // BITCOIN_NODE_TYPES_H diff --git a/src/psbt.cpp b/src/psbt.cpp index 9e59b52b41d01..19d855e4c78b2 100644 --- a/src/psbt.cpp +++ b/src/psbt.cpp @@ -4,12 +4,12 @@ #include +#include #include #include