Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swift Package Manager Support #77

Open
jurvis opened this issue May 5, 2022 · 5 comments
Open

Add Swift Package Manager Support #77

jurvis opened this issue May 5, 2022 · 5 comments

Comments

@jurvis
Copy link
Contributor

jurvis commented May 5, 2022

Essentially what is wip in #73

I recently found out that Swift 5.4 added extensible build tools to Swift Package Manager, which will allow us to support deterministic builds with Swift Package Manager, since we can use it to call our external build script to build the C static libs.

For some reason this isn't documented in the official docs for the package manifest. 🤷

@jurvis
Copy link
Contributor Author

jurvis commented May 5, 2022

@Sjors I have a couple of exams lined up and will have sparse availability over the next week, but I'll work on this during my spare time.

@Sjors
Copy link
Owner

Sjors commented May 9, 2022

Thanks!

I'm still very reluctant about binary releases, but we could make them available with a giant disclaimer that people should stick to CocoaPods until there's a source distribution.

@jurvis
Copy link
Contributor Author

jurvis commented May 9, 2022

some update here: looks like I misunderstood how that Swift evolution proposal works. It's mostly for using tools like SwiftGen to generate swift code.

I put a post up on the Swift forums to gather some thoughts, but based on the replies (N=1) so far, and my separate conversations with friends, it doesn't look like source distribution with SwiftPM is currently possible.

Disclaimer sounds good, my goal for now is to write an additional GitHub action that builds the xcframework and creates a release on tag. What do you think?

@Sjors
Copy link
Owner

Sjors commented May 9, 2022

That sounds good to me. For developers using the binary it means trusting Github instead of trusting me, which is no worse :-)

@jurvis
Copy link
Contributor Author

jurvis commented Aug 5, 2022

apologies for stalling on this. we learned a ton about how to do this nicely over at https://github.com/lightningdevkit/ldk-swift, and I'll find some way to bring them over to libwally-swift at some point.

Probably will be a lot easier since we're building libwally-core from C, not Rust 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants