Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SketchUp favicon needs updating to same used for other SketchUp sites #21

Open
DanRathbun opened this issue Jun 28, 2018 · 5 comments
Open

SketchUp favicon needs updating to same used for other SketchUp sites #21

DanRathbun opened this issue Jun 28, 2018 · 5 comments
Labels
bug

Comments

@DanRathbun
Copy link
Contributor

SketchUp favicon URL has changed causing error and standard "document" browser tab icon.

Per Caroline in the public forum

This is the link: https://www.sketchup.com/sites/all/themes/sketch_www/favicon.ico

... it is currently ...

https://help.sketchup.com/sites/all/themes/sketch_help/favicon.ico

... which gives a 404 Not Found error.

Reference public forum thread:
https://forums.sketchup.com/t/favicon-seems-to-be-missing/57625/
@DanRathbun
Copy link
Contributor Author

This is either still busted or busted again !

@thomthom
Copy link
Member

Yup, I noticed that. Got a fix in the pipeline which pulls the favicon into the template itself instead of relying on external resources.

@thomthom thomthom added the bug label May 25, 2020
@thomthom
Copy link
Member

Fix was done in this commit: fa19368

But we haven't pushed any update yet. Working on some other fixes as well.

@DanRathbun
Copy link
Contributor Author

I think has been fixed. We now see the new blue SketchUp application icon in browser tabs.

@DanRathbun
Copy link
Contributor Author

DanRathbun commented May 9, 2021 •
edited
Loading

Actually, ... the icon has a permanent white background even when a dark mode is used.

Please replace the icon here: "https://ruby.sketchup.com/favicon.ico"

... with this icon: "https://developer.sketchup.com/sites/developer.sketchup.com/files/Favicon.ico"
or this: "https://www.sketchup.com/themes/sketchup_www_terra/favicon.ico"
or this: "https://aws1.discourse-cdn.com/sketchup/optimized/3X/c/7/c746725cdbfbabf601da75a1af32622133cfacdd_2_32x32.png"

... ie, they are all the same 32x32 icon. Although the last is a PNG.

@DanRathbun DanRathbun changed the title SketchUp favicon URL has changed causing error and standard browser tab icon SketchUp favicon needs updating to same used for other SketchUp sites May 9, 2021
DanRathbun added a commit to DanRathbun/sketchup-yard-template that referenced this issue May 9, 2021
@DanRathbun
Update favicon.ico to same as other SketchUp sites
16406e1 
Update favicon.ico to same as other SketchUp sites.
Ref Issue SketchUp#21
DanRathbun added a commit to DanRathbun/sketchup-yard-template that referenced this issue May 9, 2021
@DanRathbun
Update favicon.ico to same as other SketchUp sites
425dcff 
Update favicon.ico to same as other SketchUp sites.
Ref Issue SketchUp#21
@DanRathbun DanRathbun mentioned this issue May 9, 2021
Merged
thomthom pushed a commit that referenced this issue Oct 20, 2021
@DanRathbun
Fix favicon.ico and Ruby.svg (#24)
eee33fc 
* Update favicon.ico to same as other SketchUp sites

Update favicon.ico to same as other SketchUp sites.
Ref Issue #21

* Delete Favicon.ico

* Update favicon.ico to same as other SketchUp sites

Update favicon.ico to same as other SketchUp sites.
Ref Issue #21

* Edit Ruby.svg change red to Trimble blue.

Changed all references of Ruby color #e62b3e to Trimble blue #005F9E.
Ref Issue #22

* Fix invalid relative links to favicon in forum

Fix invalid relative links to favicon in forum oneboxes.
Ref: Issue #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomthom @DanRathbun