Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Review #10

Open
GitMazzone opened this issue May 19, 2017 · 0 comments
Open

Project Review #10

GitMazzone opened this issue May 19, 2017 · 0 comments

Comments

@GitMazzone
Copy link

Just to make you aware: you've uploaded much more than just your Colmar Academy project here, all in the same repository. Also, you've included several "final" versions of your index file rather than just including the most recent - I graded index3.html.

Don't use rem for anything but font-size - that's what it's made for, as it's a scale based on the default height of fonts. In your project, it causes lots of sizing issues that prevent your content from spanning the width of the page. It's better to use px or percentages for things that aren't text.

Here's a cheat sheet for flexbox, hopefully it'll be helpful: http://jsbin.com/yaroqun/edit?html,output
A goal of this project was to use flexbox styling to align your content within and around itself, so I'd recommend considering how you might go about simplifying your code with flexbox.
One example: your rightkp section and the divs within could have been accurately positioned with the use of justify-content: space-between, and the use of the column flex-direction.

The same basic fixes apply to all of your sections, so I think the best course of action would be to look through that cheat sheet and to rework your code, either from scratch or just adjusting what you've currently got to make use of existing flexbox positioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant