Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SkyDB integration - GetEntry, SetEntry, GetJSON and SetJSON #3

Open
MSevey opened this issue Mar 22, 2021 · 2 comments
Open

SkyDB integration - GetEntry, SetEntry, GetJSON and SetJSON #3

MSevey opened this issue Mar 22, 2021 · 2 comments

Comments

@MSevey
Copy link
Contributor

MSevey commented Mar 22, 2021

Issue by kamy22
Thursday Dec 17, 2020 at 21:51 GMT
Originally opened as NebulousLabs/go-skynet#29

Implemented GetEntry, SetEntry, GetJSON, SetJSON.
Added different test cases.

More tests and SetEntryOptions, GetEntryOptions, etc... with timeout will be added in a separate PR.

kamy22 included the following code: https://github.com/NebulousLabs/go-skynet/pull/29/commits
@MSevey
Copy link
Contributor Author

MSevey commented Mar 22, 2021

Comment by m-cat
Friday Dec 18, 2020 at 14:30 GMT

Awesome, thank you for this! I'll take a look.

@MSevey
Copy link
Contributor Author

MSevey commented Mar 22, 2021

Comment by kamy22
Monday Jan 18, 2021 at 18:38 GMT

@m-cat thanks for the review. I will work on the proposed changes as soon as I have some free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MSevey