From 8ab53ac1641826f35868ebacda00377fa5a729e9 Mon Sep 17 00:00:00 2001 From: Paul-Emmanuel Raoul Date: Sun, 21 Apr 2024 19:22:27 +0200 Subject: [PATCH] Replace calls to 'Py_INCREF' with 'Py_XINCREF' The 'PyErr_NewException' function can return 'NULL', which means that 'Py_XINCREF' must be used instead of 'Py_INCREF'. See https://docs.python.org/3/extending/extending.html#null-pointers for further information. --- src/python4yahdlc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/python4yahdlc.c b/src/python4yahdlc.c index acb494b..56f1327 100644 --- a/src/python4yahdlc.c +++ b/src/python4yahdlc.c @@ -162,7 +162,7 @@ PyMODINIT_FUNC PyInit_yahdlc(void) return NULL; Yahdlc_MessageError = PyErr_NewException("yahdlc.MessageError", NULL, NULL); - Py_INCREF(Yahdlc_MessageError); + Py_XINCREF(Yahdlc_MessageError); if (PyModule_AddObject(m, "MessageError", Yahdlc_MessageError) < 0) { Py_XDECREF(Yahdlc_MessageError); Py_CLEAR(Yahdlc_MessageError); @@ -171,7 +171,7 @@ PyMODINIT_FUNC PyInit_yahdlc(void) } Yahdlc_FCSError = PyErr_NewException("yahdlc.FCSError", NULL, NULL); - Py_INCREF(Yahdlc_FCSError); + Py_XINCREF(Yahdlc_FCSError); if (PyModule_AddObject(m, "FCSError", Yahdlc_FCSError) < 0) { Py_XDECREF(Yahdlc_FCSError); Py_CLEAR(Yahdlc_FCSError);