Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Peer Dep to React 18 #234

Closed
wants to merge 1 commit into from
Closed

Conversation

zedd45
Copy link

@zedd45 zedd45 commented Nov 9, 2022

RE #227

  • upgrades peer dep
  • updates reactDOM.render to reactDOM.createRoot

PLEASE NOTE: The tests passed, but npm i failed:

npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"18.x.x" from the root project
npm ERR!   peer react@"^0.13.0 || ^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0" from [email protected]
npm ERR!   node_modules/react-ace
npm ERR!     react-ace@"^9.5.0" from the root project
npm ERR!   2 more (react-dom, react-frame-component)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"18.x.x" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"18.x.x" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See ./eresolve-report.txt for a full report.

#...

* upgrades peer dep
* updates `reactDOM.render` to `reactDOM.createRoot`
  * see [upgrade guide](https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html#updates-to-client-rendering-apis)
@kirdiapin-n
Copy link

kirdiapin-n commented Feb 8, 2023

Why is it still in draft?..

@AYColumbia
Copy link

This is still an issue as I'm working on a project with React 18 and cannot install due to old dependency.

@zedd45 zedd45 closed this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants