Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate/remove the action-flag #43

Open
AckslD opened this issue Oct 23, 2019 · 0 comments
Open

Deprecate/remove the action-flag #43

AckslD opened this issue Oct 23, 2019 · 0 comments

Comments

@AckslD
Copy link
Member

AckslD commented Oct 23, 2019

As far as I know, the only functionality of the action flag is that it lets the backend process command headers recursively. This is also visible in the lines below: on line 311 of the removed code, the method is recursively invoked. This adds unnecessary complexity for no good reason, in my opinion. Without the action flag, it is still possible to send multiple commands at once. For instance, consider the following CQC program (in pseudo-CQC):

CQC Header. Type = CQCType.COMMAND. Length = 3 command headers
Command Header. Instruction = X. Action = False
Command Header. Instruction = Y. Action = False
Command Header. Instruction = Z. Action = False

Even though action is set to False, all three commands will be executed sequentially. This is my understanding of sequences and the action flag. Am I missing something?

Regarding the trouble with the logic: During the design phase of my project, I consulted Leon to discuss some ideas and possible solutions. At that point, I had some questions regarding sequences. All these questions were answered and there are no problems anymore. In my final implementation, the sequence functionality works perfectly (albeit without the action flag, and without sequence headers).

Originally posted by @VictorPrins in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant