Remove the evil-org-set-key-theme call on load

[hlissner]

At the end of evil-org-mode.el, you've got:

;; Set customizable theme
(evil-org-set-key-theme evil-org-key-theme)

Should this not be removed? The example configurations suggest we use evil-org-set-key-theme ourselves. This means evil-org-set-key-theme will run twice in my session. This works, but is suboptimal.

In my case, my Emacs framework uses evil-org as a basis for its evil+org integration, and I'd like to support the evil-org-set-key-theme use case as documented, but it'd require a little advice/auxiliary keymap gymnastics to do so.

Alternatively, it could be guarded with, say:

(unless evil-org-key-theme
  (evil-org-set-key-theme))

---

Side note: in your more elaborate example, you're setting:

(setf evil-org-key-theme '(navigation insert textobjects additional))

But don't call evil-org-set-key-theme, so those settings are never actualized.

[Somelauw]

There are currently two ways to configure it. One way is to customize evil-org-keytheme, the other is to call evil-org-set-key-theme in your init file. If you want to avoid calling the set-up function twice, you can only customize the variable, so it's called only once at the end of the file. One way this could work is to make doom set a default for evil-org-keytheme. In that case users of doom can stick to the doom default or call evil-org-set-keytheme in their init file if they want to make a different decision.