Extract NewIssueData from PullRequestCreated #150
Merged
+259
−211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,20 +81,20 @@ export class JiraClient { | |||
| }; | |||
| }; | |||
|
|
|||
| private async sendJiraGet(endpoint: string): Promise<any> { | |||
| return this.sendJiraRequest("GET", endpoint); | |||
| private async sendRestGet(endpoint: string): Promise<any> { | |||
There was a problem hiding this comment.
The renames and refactorings here are to make room for sendGraphQL(query: any) that will call sendRequest
Comment on lines
+63
to
+66
| if (email == null) { | ||
| console.log('Could not find accountId, email is null'); | ||
| return null; | ||
| } |
There was a problem hiding this comment.
This null-check is new. Previously, this was called only after email was checked for null. Now, it's called every time.
The test org doesn't have SAML. And it applies also to bots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for the
ToDothat are in the code. There was too much logic in the action itself.There should be no functional changes
Tested here:
https://github.com/pavel-mikula-test-organization/GitHubActionPlaygroundOrganization/pull/94
https://github.com/pavel-mikula-test-organization/GitHubActionPlaygroundOrganization/pull/95