(WIP) RedundantMethodsInDataClassesCheck

SonarSource · Oct 8, 2024 · 62bc884 · 62bc884
1 parent be6aa4c
commit 62bc884
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt b/...-checks/src/main/java/org/sonarsource/kotlin/checks/RedundantMethodsInDataClassesCheck.kt
@@ -31,7 +31,6 @@ import org.jetbrains.kotlin.psi.KtNamedFunction
 import org.jetbrains.kotlin.psi.KtParameter
 import org.jetbrains.kotlin.psi.KtReturnExpression
 import org.jetbrains.kotlin.psi.psiUtil.collectDescendantsOfType
-import org.jetbrains.kotlin.resolve.BindingContext
 import org.sonar.check.Rule
 import org.sonarsource.kotlin.api.checks.ANY_TYPE
 import org.sonarsource.kotlin.api.checks.AbstractCheck
@@ -60,7 +59,6 @@ class RedundantMethodsInDataClassesCheck : AbstractCheck() {
 
     private val issueMessage = "Remove this redundant method which is the same as a default one."
 
-    // TODO easy
     override fun visitClass(klass: KtClass, context: KotlinFileContext) {
         if (!klass.isData()) return
 
@@ -71,8 +69,8 @@ class RedundantMethodsInDataClassesCheck : AbstractCheck() {
 
         klass.body?.functions?.forEach {
             when {
-                EQUALS_MATCHER.matches(it, context.bindingContext) -> equalsMethod = it
-                HASHCODE_MATCHER.matches(it, context.bindingContext) -> hashCodeMethod = it
+                EQUALS_MATCHER.matches(it) -> equalsMethod = it
+                HASHCODE_MATCHER.matches(it) -> hashCodeMethod = it
             }
         }
 
@@ -83,7 +81,7 @@ class RedundantMethodsInDataClassesCheck : AbstractCheck() {
         }
 
         hashCodeMethod?.let {
-            if (it.hashCodeHasDefaultImpl(klassParameters, context.bindingContext)) {
+            if (it.hashCodeHasDefaultImpl(klassParameters)) {
                 context.reportIssue(it.nameIdentifier!!, issueMessage)
             }
         }
@@ -92,33 +90,31 @@ class RedundantMethodsInDataClassesCheck : AbstractCheck() {
 
 private fun KtNamedFunction.hashCodeHasDefaultImpl(
     klassParameters: List<KtParameter>,
-    bindingContext: BindingContext
 ): Boolean {
     return if (hasBlockBody()) {
         val returnExpressions = collectDescendantsOfType<KtReturnExpression>()
         if (returnExpressions.size > 1) return false
-        checkHashExpression(returnExpressions[0].returnedExpression, bindingContext, klassParameters)
+        checkHashExpression(returnExpressions[0].returnedExpression, klassParameters)
     } else {
-        checkHashExpression(this.bodyExpression, bindingContext, klassParameters)
+        checkHashExpression(this.bodyExpression, klassParameters)
     }
 }
 
 private fun checkHashExpression(
     expression: KtExpression?,
-    bindingContext: BindingContext,
     klassParameters: List<KtParameter>
 ): Boolean {
     if (expression !is KtDotQualifiedExpression) return false
     if (expression.selectorExpression !is KtCallExpression) return false
 
     val callExpression = expression.selectorExpression as KtCallExpression
-    if (OBJECTS_HASH_MATCHER.matches(callExpression, bindingContext)) {
+    if (OBJECTS_HASH_MATCHER.matches(callExpression)) {
         if (callExpression.valueArguments.size != klassParameters.size) return false
         return callExpression.valueArguments.all {
             findParameter(it.getArgumentExpression(), klassParameters) != null
         }
     }
-    if (ARRAYS_HASHCODE_MATCHER.matches(callExpression, bindingContext)) {
+    if (ARRAYS_HASHCODE_MATCHER.matches(callExpression)) {
         val argumentExpression = callExpression.valueArguments[0].getArgumentExpression()
         if (argumentExpression !is KtCallExpression) return false
         val arguments = argumentExpression.valueArguments