SONARSCALA-33 Update scapegoat rules mapping (#34)

SonarSource · Nov 28, 2024 · 74ab5c8 · 74ab5c8
1 parent f212043
commit 74ab5c8
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/sonar-scala-plugin/src/main/resources/org/sonar/l10n/scala/rules/scapegoat/rules.json b/sonar-scala-plugin/src/main/resources/org/sonar/l10n/scala/rules/scapegoat/rules.json
@@ -1,4 +1,11 @@
 [
+  {
+    "key": "com.sksamuel.scapegoat.inspections.AvoidRequire",
+    "name": "Use of require",
+    "type": "CODE_SMELL",
+    "severity": "MAJOR",
+    "url": "https://github.com/sksamuel/scapegoat/blob/master/README.md#inspections"
+  },
   {
     "key": "com.sksamuel.scapegoat.inspections.AvoidToMinusOne",
     "name": "Checks for loops that use `x to n-1` instead of `x until n`",
@@ -773,6 +780,13 @@
     "severity": "MINOR",
     "url": "https://github.com/sksamuel/scapegoat/blob/master/README.md#inspections"
   },
+  {
+    "key": "com.sksamuel.scapegoat.inspections.traits.AbstractTrait",
+    "name": "Check if trait is abstract",
+    "type": "CODE_SMELL",
+    "severity": "MINOR",
+    "url": "https://github.com/sksamuel/scapegoat/blob/master/README.md#inspections"
+  },
   {
     "key": "com.sksamuel.scapegoat.inspections.unneccesary.ConstantIf",
     "name": "Checks for code where the if condition compiles to a constant",

diff --git a/...est/java/org/sonarsource/scala/externalreport/scapegoat/ScapegoatRulesDefinitionTest.java b/...est/java/org/sonarsource/scala/externalreport/scapegoat/ScapegoatRulesDefinitionTest.java
@@ -35,7 +35,7 @@ void external_repository() {
     assertThat(repository.name()).isEqualTo("Scapegoat");
     assertThat(repository.language()).isEqualTo("scala");
     assertThat(repository.isExternal()).isTrue();
-    assertThat(repository.rules()).hasSize(121);
+    assertThat(repository.rules()).hasSize(123);
 
     RulesDefinition.Rule rule = repository.rule("com.sksamuel.scapegoat.inspections.AvoidToMinusOne");
     assertThat(rule).isNotNull();