Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It is easy to mix up find_by_activation_token and load_from_activation_token #345

Open
joshbuker opened this issue May 21, 2023 · 0 comments

Comments

@joshbuker
Copy link
Member

While writing tests for v1, I accidentally used find_by instead of load_from, which had me scratching my head as to why the test was finding the record even when set to nil. This is an easy mistake to make, and a potential security vulnerability - need to find some way to refactor this that makes it difficult or impossible to mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant