Skip to content

examples/all-findings cannot be built or checked at all — missing workspace membership/exclude declaration #372

Description

@unrealtim-tech

Labels: bug, ci
Crate: workspace

Description
examples/all-findings/Cargo.toml has no [workspace] table, and the root Cargo.toml's members/exclude lists neither includes nor excludes examples/all-findings (only test-contracts is excluded). Since the crate sits inside the workspace root's directory tree, Cargo treats it as an orphaned workspace member and refuses to build it:

$ cd examples/all-findings && cargo check
error: current package believes it's in a workspace when it's not:
current:   .../examples/all-findings/Cargo.toml
workspace: .../Cargo.toml

this may be fixable by adding `examples/all-findings` to the `workspace.members` array of the manifest located at: .../Cargo.toml
Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.

This is a distinct, more fundamental problem than issue #308 (which is about the example no longer triggering every check) — the crate can't even be type-checked, by anyone, in any state, until this is fixed. .github/workflows/ci.yml never touches examples/ at all, so this has never been caught by CI.

Acceptance Criteria

  • Add examples/all-findings to the root Cargo.toml's exclude list (matching the test-contracts treatment), or add an empty [workspace] table to examples/all-findings/Cargo.toml to opt it out explicitly.
  • Add a CI step that runs cargo check against examples/all-findings, similar to the existing per-fixture loop for test-contracts/*/.

Difficulty: beginner

Metadata

Metadata

Assignees

No one assigned

    Labels

    Stellar WaveIssues in the Stellar wave programbugSomething isn't workingci

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions