`crates/cli/tests/fixture_scans.rs` tests exclusively via `scan_directory`, which dedupes — masking bugs in the CLI's real `scan_directory_with_checks` path

[unrealtim-tech]

Labels: testing, cli-crate
Crate: cli

Description
Every test in crates/cli/tests/fixture_scans.rs calls soroban_guard_analyzer::scan_directory (imported at line 1), which internally calls dedup_findings before returning. But issue #309 established that the actual CLI (crates/cli/src/main.rs) calls scan_directory_with_checks instead — which, per crates/analyzer/src/lib.rs, does not call dedup_findings at all.

This means the entire fixture test suite validates a code path real users never take, and is structurally incapable of catching CLI-path-specific bugs like duplicate findings (e.g. the AuthAfterStorageWriteCheck double-registration filed separately) — scan_directory's dedup step silently absorbs exactly that kind of defect before the test ever sees it. This is a different gap than the already-open #291 (which is about missing coverage for most checks); this is about the coverage that already exists testing the wrong underlying function.

Acceptance Criteria

• Add at least one test in fixture_scans.rs (or a new integration test file) that goes through scan_directory_with_checks + default_checks_with_config(...), matching the CLI's real invocation, and assert it produces no duplicate (file, line, check_name) findings.
• Consider whether assert_fixture_pair should be parameterized to run against both entry points.

Difficulty: intermediate

[brite-side0]

@brite-side0 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hello maintainer,

I’m a Full Stack Blockchain, Mobile, and Software Engineer with experience building scalable and production ready applications.

I’ve reviewed this particular issue and understand its requirements. If assigned, I’ll begin work immediately, provide regular updates, and deliver a clean, well-tested, and maintainable solution that meets the project’s standards.

Looking forward to contributing.

ℹ️ Repo Maintainers: To accept this application, review their application or assign @brite-side0 to this issue.

[Hunterly01]

@Hunterly01 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would love to work on this issue professionally, please assign it to me

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Hunterly01 to this issue.

[OLAMIGHTY010]

@OLAMIGHTY010 has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would like to work on this project

ℹ️ Repo Maintainers: To accept this application, review their application or assign @OLAMIGHTY010 to this issue.

[Mhidesav]

@Mhidesav has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi
I would like to work on this issue please 🙏

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mhidesav to this issue.

[Horlarmmy]

@Horlarmmy has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

Hi, I'd like to quickly pick up this issue. Kindly assign

ℹ️ Repo Maintainers: To accept this application, review their application or assign @Horlarmmy to this issue.

[devcarole]

@devcarole has applied to work on this issue as part of the Stellar Wave Program's 7th wave.

I would like to work on this issue

ℹ️ Repo Maintainers: To accept this application, review their application or assign @devcarole to this issue.