[PROPOSAL] Implement strict null comparison

[bluec]

Prerequisites

• Able to reproduce the behaviour outside of your code, the problem is isolated to Laravel Excel.
• Checked that your issue isn't already filed.
• Checked if no PR was submitted that fixes this problem.

Versions

• PHP version: 8.1
• Laravel version: 8.83.8
• Nova version: 3.32.0
• Package version: Nova Excel 1.2.10 and Laravel Excel 3.1.40

Description

Can't enable strict null comparison

Steps to Reproduce

Two ways I have tried:

1. Publish the config/excel.php from the underlying Laravel Excel package and change strict_null_comparison to true
2. Overload the \Maatwebsite\LaravelNovaExcel\Actions\DownloadExcel class with a new class that implements the WithStrictNullComparison concern

Expected behavior:

With strict null comparison enabled, zero values in the database should export as zeros.

Actual behavior:

Zero values in the database export as null (empty cells).

Additional Information

This isn't an issue with the underlying Laravel Excel package - it works there.

I initially thought this was a bug but actually looking at the code I think it is just not implemented in this package so I have changed this to a proposal. I think it's possible to overcome this by creating a custom action but this is quite cumbersome.

Would be nice to see this implemented in the Nova package because I think it's quite important especially when dealing with Boolean fields in Laravel.

[Monomachus]

What you need to do is something like this

php artisan vendor:publish --provider="Maatwebsite\Excel\ExcelServiceProvider" --tag=config

then you'd need to change the key 'strict_null_comparison' to true

'strict_null_comparison' => true,

[bluec]

What you need to do is something like this

php artisan vendor:publish --provider="Maatwebsite\Excel\ExcelServiceProvider" --tag=config

then you'd need to change the key 'strict_null_comparison' to true

'strict_null_comparison' => true,

It's 3 years since I raised this request, and at that time, as per my description, changing the strict_null_comparison to true in the underlying Maatwebsite\Excel package had no effect in the Nova package.

Are you saying it now works? Can you provide evidence or the code changes/PR where this was fixed in the Nova package?