Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #33

Open
PhilippSchuette opened this issue Apr 27, 2023 · 2 comments
Open

Improve test coverage #33

PhilippSchuette opened this issue Apr 27, 2023 · 2 comments
Assignees
@PhilippSchuette
Labels
enhancement Enhance an existing feature

Comments

@PhilippSchuette
Copy link
Member

At the moment the test coverage for the two modules settings and plugins is quite low in comparison with the rest. Additional tests should be implemented to remedy this situation.
@PhilippSchuette PhilippSchuette self-assigned this Apr 27, 2023
@PhilippSchuette PhilippSchuette added the enhancement Enhance an existing feature label Apr 27, 2023
@PhilippSchuette
Copy link
Member Author

In addition, setting verbose=False for all root finder tests affects coverage of rootfinder.py and parallel_finder.py in quite a bad way. This should be fixed by mocking a FinderProgressBar. To make this easier the concrete instantiation within the RootFinder should be replaced by resolving the bar from the ServiceLocator.

@PhilippSchuette
Copy link
Member Author

Argument estimation with order>0 lacks testing as well right now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippSchuette PhilippSchuette

Labels
enhancement Enhance an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PhilippSchuette