Move chart subcrate to module of sseq

JoeyBF · JoeyBF · commit 61e8bdf4416d · 2025-11-13T03:21:14.000-05:00
diff --git a/ext/Cargo.toml b/ext/Cargo.toml
@@ -15,7 +15,6 @@ resolver = "2"
 [dependencies]
 algebra = { path = "crates/algebra", default-features = false }
 bivec = { path = "crates/bivec" }
-chart = { path = "crates/chart" }
 fp = { path = "crates/fp", default-features = false }
 maybe-rayon = { path = "crates/maybe-rayon" }
 once = { path = "crates/once" }
@@ -65,7 +64,6 @@ nassau = []
 members = [
     "crates/algebra",
     "crates/bivec",
-    "crates/chart",
     "crates/fp",
     "crates/maybe-rayon",
     "crates/once",
diff --git a/ext/crates/chart/Cargo.toml b/ext/crates/chart/Cargo.toml
diff --git a/ext/crates/sseq/Cargo.toml b/ext/crates/sseq/Cargo.toml
@@ -7,7 +7,6 @@ edition = "2024"
 
 [dependencies]
 bivec = { path = "../bivec/" }
-chart = { path = "../chart/" }
 fp = { path = "../fp/", default-features = false }
 maybe-rayon = { path = "../maybe-rayon" }
 once = { path = "../once/" }
diff --git a/ext/crates/sseq/legend.svg b/ext/crates/sseq/legend.svg
diff --git a/ext/crates/sseq/src/charting.rs b/ext/crates/sseq/src/charting.rs
@@ -1,5 +1,3 @@
-#![deny(clippy::use_self, unsafe_op_in_unsafe_fn)]
-
 use std::{collections::HashMap, fmt::Display, io};
 
 #[rustfmt::skip]
diff --git a/ext/crates/sseq/src/lib.rs b/ext/crates/sseq/src/lib.rs
@@ -1,6 +1,7 @@
 #![deny(clippy::use_self, unsafe_op_in_unsafe_fn)]
 
 mod bigraded;
+pub mod charting;
 pub mod coordinates;
 mod differential;
 mod sseq;
diff --git a/ext/crates/sseq/src/sseq.rs b/ext/crates/sseq/src/sseq.rs
@@ -457,7 +457,7 @@ impl<P: SseqProfile> Sseq<P> {
     }
 
     /// This shifts the sseq horizontally so that the minimum x is 0.
-    pub fn write_to_graph<'a, T: chart::Backend>(
+    pub fn write_to_graph<'a, T: crate::charting::Backend>(
         &self,
         mut g: T,
         r: i32,
diff --git a/ext/examples/chart.rs b/ext/examples/chart.rs
@@ -1,9 +1,9 @@
 use algebra::Algebra;
-use chart::SvgBackend;
 use ext::{
     chain_complex::{ChainComplex, FreeChainComplex},
     utils::query_module,
 };
+use sseq::charting::SvgBackend;
 
 fn main() -> anyhow::Result<()> {
     ext::utils::init_logging()?;
diff --git a/ext/examples/d2_charts.rs b/ext/examples/d2_charts.rs
@@ -1,11 +1,11 @@
 use std::{fs::File, sync::Arc};
 
 use algebra::Algebra;
-use chart::{Backend as _, TikzBackend as Backend};
 use ext::{
     chain_complex::{ChainComplex, FreeChainComplex},
     secondary::{SecondaryLift, SecondaryResolution},
 };
+use sseq::charting::{Backend as _, TikzBackend as Backend};
 
 fn main() -> anyhow::Result<()> {
     ext::utils::init_logging()?;
diff --git a/ext/examples/unstable_chart.rs b/ext/examples/unstable_chart.rs
@@ -22,12 +22,14 @@ use algebra::{
     Algebra,
     module::{Module, SuspensionModule},
 };
-use chart::{Backend, Orientation, TikzBackend};
 use ext::{
     chain_complex::{FiniteChainComplex, FreeChainComplex},
     resolution::UnstableResolution,
 };
-use sseq::coordinates::Bidegree;
+use sseq::{
+    charting::{Backend, Orientation, TikzBackend},
+    coordinates::Bidegree,
+};
 
 fn main() -> anyhow::Result<()> {
     ext::utils::init_logging()?;
diff --git a/ext/src/lib.rs b/ext/src/lib.rs
@@ -143,7 +143,6 @@
 //! | --- | --- |
 //! | [algebra] | This defines algebras, modules and module homomorphisms |
 //! | [bivec] | This is a small crate that provides [`BiVec`](`bivec::BiVec`) - a variant of [`Vec`] indexed by an `i32` whose starting index may be non-zero. |
-//! | [chart] | This provides some APIs for generating charts |
 //! | [fp] | This implements linear algebra over $\mathbb{F}_p$, as well as general helper functions about primes. |
 //! | [once] | This provides `OnceVec` and `OnceBiVec`, a push-only vector with non-blocking reads. This models some partially computed infinite data structure, and we think of pushing as simply finding out more of this infinite data structure instead of genuinely mutating it. |
 //! | [query] | This contains some helper functions for a command line interface. |

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-#![deny(clippy::use_self, unsafe_op_in_unsafe_fn)]`
`2`		`-`
`3`	`1`	`use std::{collections::HashMap, fmt::Display, io};`
`4`	`2`
`5`	`3`	`#[rustfmt::skip]`
Original file line number	Diff line number	Diff line change
`@@ -457,7 +457,7 @@ impl<P: SseqProfile> Sseq<P> {`
`457`	`457`	`}`
`458`	`458`
`459`	`459`	`/// This shifts the sseq horizontally so that the minimum x is 0.`
`460`		`- pub fn write_to_graph<'a, T: chart::Backend>(`
	`460`	`+ pub fn write_to_graph<'a, T: crate::charting::Backend>(`
`461`	`461`	`&self,`
`462`	`462`	`mut g: T,`
`463`	`463`	`r: i32,`