Skip to content

Optimize nassau::Resolution::write_qi #102

@JoeyBF

Description

@JoeyBF

Right now this line

scratch.as_slice_mut().add(full_matrix.row(i), 1);

is extremely hot. I would even say it's one of the main bottlenecks to computing at large stems. Looking at active threads with top and running pstack on them periodically, it seems I usually have only a handful of threads running, and they are all executing that line. (See #101 for more detailed logging)

If I'm reading this correctly, this code looks like it's doing some vector-vector operations repeatedly. Would this be a good candidate to replace with vector-matrix or matrix-matrix operations? In the latter case #100 will probably give a massive speedup.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions