Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire.usePullups() stopped working after version 2.6.1 #1158

Open
jvasileff opened this issue Oct 29, 2024 · 5 comments
Open

Wire.usePullups() stopped working after version 2.6.1 #1158

jvasileff opened this issue Oct 29, 2024 · 5 comments
Assignees
Labels
bug Something isn't working design decision A design decision is needed prior to implementation.

Comments

@jvasileff
Copy link
Contributor

As can be confirmed with a multimeter and the following setup code:

Wire.usePullups();
Wire.begin();

Wire.usePullups() stopped pulling PB0 and PB1 high with version 2.6.2 or 2.6.3. This was tested with an attiny1627.

@MX682X
Copy link
Contributor

MX682X commented Oct 30, 2024

#elif defined(MEGATINYCORE) && MEGATINYCORE_SERIES != 2 /* tinyAVR 0/1-series */

could you try the newest version but remove the right part of the #if conditional ( " && MEGATINYCORE_SERIES != 2 ")? I don't have a 2-Series to test

@jvasileff
Copy link
Contributor Author

Thanks! Indeed, that does fix Wire.usePullups() on 2.6.10. I just did a quick test with a multimeter, I didn't try to actually use i2c with this change.

@jvasileff
Copy link
Contributor Author

I've now tested actually using i2c with this change - everything works great.

@SpenceKonde
Copy link
Owner

There are CONSIDERABLY more serious issues here. Much more complicated than implied here.

@SpenceKonde SpenceKonde self-assigned this Nov 1, 2024
@SpenceKonde SpenceKonde added bug Something isn't working design decision A design decision is needed prior to implementation. labels Nov 1, 2024
@MX682X
Copy link
Contributor

MX682X commented Nov 1, 2024

How so?
As far as I can see the use Pullups function isn't doing anything in the 2 series.
all we have to do is to #if def the OUTCLR, however I think it would be sensible to just keep it like that - I doubt anyone will end up using I2C pins on a PCB for anything but I2C

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working design decision A design decision is needed prior to implementation.
Projects
None yet
Development

No branches or pull requests

3 participants