Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live interactive spike io #16

Open
tmarinakis opened this issue Sep 12, 2018 · 2 comments
Open

Live interactive spike io #16

tmarinakis opened this issue Sep 12, 2018 · 2 comments
Labels
Milestone

Comments

@tmarinakis
Copy link

When the simulation finishes, I can still inject

@andrewgait
Copy link
Contributor

It's been a while since this issue was posted; I'm not sure why it's a problem that you can still click the button to "inject" after the simulation has finished, as it doesn't make any difference to the results and doesn't cause anything to crash.

@dkfellows dkfellows added this to the 5.1.0 milestone Aug 12, 2019
@alan-stokes
Copy link
Contributor

this would likely cause a issue with multi run. think of this:

  1. run
  2. complete first run
  3. inject....oh lets say 17 packets to a core on 0,0.
    so now the buffer (i think is 16 in size) on the core is full, and 1 is bouncing back and forth from the router and the core. might get dropped, but might not
  4. send new runtime, crashes due to that core being full of buffered injected packets that haven't been processed due to the core not receiving packets

or even worse, it doesnt fail, and now youve got a massive burst from that core when it starts up again in the second run.

either case is not ideal. I guess we just put the injector onto a safety check and blow up if you ask to inject when its in pause state

@Christian-B Christian-B modified the milestones: 5.1.0, 6.0.0 Jul 8, 2020
@dkfellows dkfellows modified the milestones: 6.0.0, 7.0.0 Apr 13, 2021
Christian-B pushed a commit that referenced this issue May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants