Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove protocol from PushBotEthernetDevice #1423

Open
Christian-B opened this issue Dec 19, 2023 · 2 comments
Open

remove protocol from PushBotEthernetDevice #1423

Christian-B opened this issue Dec 19, 2023 · 2 comments
Assignees
@rowleya

Comments

@Christian-B
Copy link
Member

The class PushBotEthernetDevice has a setter and getter for a "protocol"

However the two "protocol" classes are so different they do not even share a common API.

So it does not make sense to story this at the Abstract level.

As the Set and Get would have to be typed "Any"
@Christian-B
Copy link
Member Author

On farther examination the "protocol" is always a MunichIoSpiNNakerLinkProtocol in contrast to what the docs claim.

MunichIoEthernetProtocol is actually just a utils class

@Christian-B
Copy link
Member Author

Will fix in the overrides pr

@Christian-B Christian-B reopened this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rowleya rowleya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Christian-B @rowleya