Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations for weekdays #45

Open
GanovenEde opened this issue Mar 8, 2022 · 4 comments
Open

Missing translations for weekdays #45

GanovenEde opened this issue Mar 8, 2022 · 4 comments

Comments

@GanovenEde
Copy link

Hello. Great app, I'm using it for months now.

But there is one thing that bothers me a little: weekdays are shown in English (Mon, Tue, Wed, ...) even if another language has been selected.

Would it be possible to fix this?

Thank you.

@SpicyChair
Copy link
Owner

Translating and abbreviating the weekdays from other languages might be a bit difficult - would something like a "day number" work better? As in, MON -> 1?

@GanovenEde
Copy link
Author

Maybe this document helps:
https://www.ema.europa.eu/en/documents/other/abbreviation-names-days-calendarised-blisters_en.pdf

Using numbers would cause confusion, I guess.

@acuz
Copy link

acuz commented Nov 13, 2022

Hi @SpicyChair , would changing line 65 of the file daily_cart.dart in this way work?
Now: "${weekDay.substring(0, 3).toUpperCase()}",
Correction: "${Language.getTranslation(weekDay.substring(0, 3)).toUpperCase()}",

Of course Language.get should point to the keys in localization.dart.
I can help with the implementation for each language in localization.dart using the link by @GanovenEde. If we don't know the translation for some language we can leave it in English.

@GanovenEde
Copy link
Author

Hi! Would be happy to see any progress here. Incompletely localized apps often make a suspicious impression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants