Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMS in F-Droid build #55

Open
linsui opened this issue Jul 13, 2022 · 4 comments
Open

GMS in F-Droid build #55

linsui opened this issue Jul 13, 2022 · 4 comments

Comments

@linsui
Copy link

linsui commented Jul 13, 2022 •
edited
Loading

geolocator pulls in GMS, see https://github.com/Baseflow/flutter-geolocator/blob/28c8657b370abe1caf93c24b382d4dce5b5c460f/geolocator_android/android/build.gradle#L45. You can use https://gitlab.com/hanntech-gmbh/free2pass/flutter-geolocator-floss instead. The geolocator-floss is already used... Then the nonfree libs may com from somewhere else. It's not used anymore. So that's the problem. Could you please take a look? Thanks!

2022-07-13 11:19:13,698 DEBUG: > /opt/android-sdk/build-tools/31.0.0/dexdump /tmp/tmpdmptos5k/classes.dex
2022-07-13 11:19:14,386 DEBUG: Found class 'com/google/android/gms/auth/api/signin/GoogleSignInAccount'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/location/LocationRequest'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/b'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/BasePendingResult'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/location/a'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/internal/c'
2022-07-13 11:19:14,387 DEBUG: Found class 'com/google/android/gms/common/api/b'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/common/api/a'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/common/api/Scope'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/auth/api/signin/a'
2022-07-13 11:19:14,388 DEBUG: Found class 'com/google/android/gms/dynamite/DynamiteModule'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/annotation/KeepName'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/api/internal/LifecycleCallback'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/api/GoogleApiActivity'
2022-07-13 11:19:14,389 DEBUG: Found class 'com/google/android/gms/common/util/DynamiteApi'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/LocationAvailability'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/common/internal/ReflectedParcelable'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/common/api/Status'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/b'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/c'
2022-07-13 11:19:14,390 DEBUG: Found class 'com/google/android/gms/location/LocationResult'
2022-07-13 11:19:14,391 DEBUG: Found class 'com/google/android/gms/common/api/internal/a'
@SpicyChair
Copy link
Owner

Hmm. That's odd - I can't find any mentions of GMS in the source. I'll keep investigating, thanks for bringing this up.

@linsui
Copy link
Author

linsui commented Aug 4, 2022

Mapbox may also pulls in GMS.

SpicyChair added a commit that referenced this issue Aug 4, 2022
@SpicyChair
Use FLOSS geolocator (#55)
258d0fd
@SpicyChair
Copy link
Owner

I'm not sure when or why I removed the FLOSS geolocator import... It's back now.

It should be fixed now.

@linsui
Copy link
Author

linsui commented Aug 6, 2022 

2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/common/annotation/KeepName'
2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/dynamite/DynamiteModule'
2022-08-06 13:53:36,799 DEBUG: Found class 'com/google/android/gms/auth/api/signin/GoogleSignInAccount'
2022-08-06 13:53:36,800 DEBUG: Found class 'com/google/android/gms/location/c'
2022-08-06 13:53:36,800 DEBUG: Found class 'com/google/android/gms/common/api/internal/a'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/location/a'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/internal/ReflectedParcelable'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/api/internal/BasePendingResult'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/location/b'
2022-08-06 13:53:36,801 DEBUG: Found class 'com/google/android/gms/common/api/Scope'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/internal/LifecycleCallback'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/b'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/common/api/Status'
2022-08-06 13:53:36,802 DEBUG: Found class 'com/google/android/gms/location/LocationRequest'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/common/util/DynamiteApi'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/common/api/internal/b'
2022-08-06 13:53:36,803 DEBUG: Found class 'com/google/android/gms/location/LocationAvailability'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/common/api/internal/c'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/location/LocationResult'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/auth/api/signin/a'
2022-08-06 13:53:36,804 DEBUG: Found class 'com/google/android/gms/common/api/GoogleApiActivity'
2022-08-06 13:53:36,805 DEBUG: Found class 'com/google/android/gms/common/api/a'

The classes is still in the apk. Not sure if they are from the mapbox.

@SpicyChair SpicyChair reopened this Aug 6, 2022
SpicyChair added a commit that referenced this issue Sep 4, 2022
@SpicyChair
Remove FDroid link for now (#55) (#56)
64a0947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@linsui @SpicyChair