Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication for screenshots #134

Open
tacman opened this issue Mar 15, 2024 · 1 comment
Open

Add authentication for screenshots #134

tacman opened this issue Mar 15, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@tacman
Copy link
Contributor

tacman commented Mar 15, 2024

Description

If I want a screenshot of /my-profile, the user needs to be logged in.

Example

bin/console pwa:create:screenshot https://127.0.0.1:8003/my-profile

screenshot-1200x1100

I think panther has some support for this, but I don't really know. Maybe

bin/console pwa:create:screenshot https://127.0.0.1:8003/my-profile --username=tac --password=my.password
@Spomky Spomky self-assigned this Mar 18, 2024
@Spomky Spomky added the enhancement New feature or request label Mar 18, 2024
@Spomky Spomky added this to the 1.2.0 milestone Mar 18, 2024
@Spomky Spomky modified the milestones: 1.2.0, 2.0.0 Apr 24, 2024
@tacman
Copy link
Contributor Author

tacman commented Sep 5, 2024

As an alternative, how about the option to pass a header when taking the screenshot, which could include some sort of cookie or authentication. It's messier, of course, but adding login is probably more complicated than it's worth.

If #138 worked, I'd probably take the screenshots locally and disable security, though that's not very feasible either. Passing a header, though clunky, would work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants