Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INS doesn't have faction name #107

Open
mahtoid opened this issue Apr 20, 2024 · 1 comment
Open

INS doesn't have faction name #107

mahtoid opened this issue Apr 20, 2024 · 1 comment
Assignees
@Shanomac99
Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps

Comments

@mahtoid
Copy link

mahtoid commented Apr 20, 2024

image
@Shanomac99 Shanomac99 self-assigned this Apr 22, 2024
@Shanomac99 Shanomac99 added bug Bug verified by a contributor or others In Progress corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps and removed In Progress labels Apr 22, 2024
@Shanomac99
Copy link
Collaborator

Issue is with short name being used to look up the faction table. The shortname on the faction setup table does not match the faction table for what ever reason
image
image

Changed to use the ID, should fix it.

Shanomac99 added a commit that referenced this issue Apr 22, 2024
@Shanomac99
Fixes #110
ae06999 
Fixes #107
Fixes #108
- Adds a new key "objectDisplayName" to objectives.
Shanomac99 referenced this issue Jun 17, 2024
@Shanomac99
Update to 8.0
0a51f66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shanomac99 Shanomac99

Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shanomac99 @mahtoid