Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jensen's default units not added to "Units" object. #110

Open
Shanomac99 opened this issue Apr 22, 2024 · 2 comments
Open

Jensen's default units not added to "Units" object. #110

Shanomac99 opened this issue Apr 22, 2024 · 2 comments
Assignees
@Shanomac99
Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps

Comments

@Shanomac99
Copy link
Collaborator

The default units for Jensen's range are not being added to the units object due to them not showing up in the unit list. A special check will need to be added for them to be added to the units object.
@Shanomac99 Shanomac99 added the bug Bug verified by a contributor or others label Apr 22, 2024
@Shanomac99 Shanomac99 self-assigned this Apr 22, 2024
@Shanomac99 Shanomac99 added the corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps label Apr 22, 2024
Shanomac99 added a commit that referenced this issue Apr 22, 2024
@Shanomac99
Fixes #110
ae06999 
Fixes #107
Fixes #108
- Adds a new key "objectDisplayName" to objectives.
@mahtoid
Copy link

mahtoid commented Apr 22, 2024

@Shanomac99 still an issue

Shanomac99 added a commit that referenced this issue Apr 23, 2024
@Shanomac99
Fix an issue with naming conventions of default units
45ed394 
Fixes #110
@Shanomac99
Copy link
Collaborator Author

Shanomac99 commented Apr 23, 2024 •
edited
Loading

It was an issue with naming, should be fixed. The template names in the map have changed.

Shanomac99 referenced this issue Jun 17, 2024
@Shanomac99
Update to 8.0
0a51f66
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Shanomac99 Shanomac99

Labels
bug Bug verified by a contributor or others corrected but needs data extracted The issue or feature request was fixed/add but the data needs to be extracted for all maps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Shanomac99 @mahtoid