Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(opacity): bump disabled opacity to 0.55 #1860

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

chore(opacity): bump disabled opacity to 0.55 #1860

wants to merge 2 commits into from

Conversation

dancormier
Copy link
Contributor

@dancormier dancormier commented Nov 22, 2024 •
edited by CGuindon
Loading

STACKS-590

Description tbd

Acceptance Criteria

  • Bump the opacity for disabled button to 55%
  • Explore if we can test disabled button for a11y color contrast in Stacks Classic

Before

Screenshot 2024-11-28 at 8 23 27 AM

After (very subtle)

Screenshot 2024-11-28 at 8 25 07 AM

@netlify Netlify
Copy link

netlify bot commented Nov 22, 2024 •
edited
Loading

❌ Deploy Preview for stacks failed. Why did it fail? →

Name Link
🔨 Latest commit 165b066
🔍 Latest deploy log https://app.netlify.com/sites/stacks/deploys/6744fe13db0c5a00087cfcbf

CGuindon
CGuindon approved these changes Nov 28, 2024
View reviewed changes
Copy link
Collaborator

@CGuindon CGuindon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the a11y tests pass, this LGTM — confirmed it's bumped to 55%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CGuindon CGuindon CGuindon approved these changes

@giamir giamir Awaiting requested review from giamir

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dancormier @CGuindon